From: Victor Stinner <victor.stinner@gmail.com>
Date: Wed, 13 Sep 2017 12:53:10 +0000 (-0700)
Subject: bpo-31448, test_poplib: Fix ResourceWarning (#3542)
X-Git-Tag: v3.7.0a1~57
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d165e14e29b45a22450263722f5c2c386c3a748a;p=python

bpo-31448, test_poplib: Fix ResourceWarning (#3542)

Call POP3.close(), don't close close directly the sock attribute.
---

diff --git a/Lib/test/test_poplib.py b/Lib/test/test_poplib.py
index d7a26bc14c..721ea25201 100644
--- a/Lib/test/test_poplib.py
+++ b/Lib/test/test_poplib.py
@@ -488,7 +488,7 @@ class TestTimeouts(TestCase):
         finally:
             socket.setdefaulttimeout(None)
         self.assertEqual(pop.sock.gettimeout(), 30)
-        pop.sock.close()
+        pop.close()
 
     def testTimeoutNone(self):
         self.assertIsNone(socket.getdefaulttimeout())
@@ -498,12 +498,12 @@ class TestTimeouts(TestCase):
         finally:
             socket.setdefaulttimeout(None)
         self.assertIsNone(pop.sock.gettimeout())
-        pop.sock.close()
+        pop.close()
 
     def testTimeoutValue(self):
         pop = poplib.POP3(HOST, self.port, timeout=30)
         self.assertEqual(pop.sock.gettimeout(), 30)
-        pop.sock.close()
+        pop.close()
 
 
 def test_main():