From: Emden R. Gansner <erg@research.att.com>
Date: Wed, 11 Sep 2013 00:46:32 +0000 (-0400)
Subject: Turn off aspect attribute in dot until it can be fixed
X-Git-Tag: LAST_LIBGRAPH~32^2~8^2~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d12f31790618bb38919afc94f3201278af47774b;p=graphviz

Turn off aspect attribute in dot until it can be fixed
---

diff --git a/doc/info/attrs.html b/doc/info/attrs.html
index 2d10f29ed..df1aae7a2 100644
--- a/doc/info/attrs.html
+++ b/doc/info/attrs.html
@@ -574,7 +574,11 @@ This field indicates which graph component uses the attribute.
   See the <A HREF=#h:undir_note>limitation</A>.
 
 <DT><A NAME=d:aspect HREF=#a:aspect><STRONG>aspect</STRONG></A>
-<DD>  Target aspect ratio (width of the layout divided by the height)
+<DD>  <B>NOTE</B>: As of 2.35 and until further notice, 
+  dot will not support the <TT>aspect</TT>
+  attribute. There are some significant flaws in the implementation.
+  <P>
+  Target aspect ratio (width of the layout divided by the height)
   of the graph drawing. If unset, dot minimizes the total edge length.
   For certain graphs, like those with large fan-in or fan-out, this can
   lead to very wide layouts. Setting <TT>aspect</TT> will cause dot to try
diff --git a/doc/infosrc/attrs b/doc/infosrc/attrs
index f6a775e97..88a76cfc4 100644
--- a/doc/infosrc/attrs
+++ b/doc/infosrc/attrs
@@ -93,6 +93,10 @@ This will only appear if the <A HREF=#d:dir>dir</A> attribute
 is "back" or "both".
 See the <A HREF=#h:undir_note>limitation</A>.
 :aspect:G:aspectType; dot
+<B>NOTE</B>: As of 2.35 and until further notice, 
+dot will not support the <TT>aspect</TT>
+attribute. There are some significant flaws in the implementation.
+<P>
 Target aspect ratio (width of the layout divided by the height)
 of the graph drawing. If unset, dot minimizes the total edge length.
 For certain graphs, like those with large fan-in or fan-out, this can
diff --git a/lib/dotgen/aspect.c b/lib/dotgen/aspect.c
index c55533ea6..7fe895d27 100644
--- a/lib/dotgen/aspect.c
+++ b/lib/dotgen/aspect.c
@@ -1988,6 +1988,7 @@ setAspect (Agraph_t * g, aspect_t* adata)
 	adata->badGraph = 0;
 	return NULL;
     }
+    agerr(AGWARN, "The aspect attribute is currently disabled in dot - ignored\n");
     
     if (rv < MIN_AR) rv = MIN_AR;
     else if (rv > MAX_AR) rv = MAX_AR;