From: Ulf Wendel Date: Mon, 30 Aug 2010 09:20:48 +0000 (+0000) Subject: If you add functions to the PDO core, take care not to break other PDO drivers tests... X-Git-Tag: php-5.3.4RC1~305 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d0e7e5aa2af4f82499be61e01b77024c24b2911b;p=php If you add functions to the PDO core, take care not to break other PDO drivers tests, document the function and provide a function test for the PDO core to check your default/fallback implementation. --- diff --git a/ext/pdo_mysql/tests/pdo_mysql_interface.phpt b/ext/pdo_mysql/tests/pdo_mysql_interface.phpt index 00c282bcc7..9e13908a5a 100644 --- a/ext/pdo_mysql/tests/pdo_mysql_interface.phpt +++ b/ext/pdo_mysql/tests/pdo_mysql_interface.phpt @@ -14,20 +14,21 @@ if (false == MySQLPDOTest::detect_transactional_mysql_engine($db)) $db = MySQLPDOTest::factory(); $expected = array( - '__construct' => true, - 'prepare' => true, - 'beginTransaction' => true, + '__construct' => true, + 'prepare' => true, + 'beginTransaction' => true, 'commit' => true, - 'rollBack' => true, - 'setAttribute' => true, + 'rollBack' => true, + 'setAttribute' => true, 'exec' => true, 'query' => true, - 'lastInsertId' => true, - 'errorCode' => true, - 'errorInfo' => true, - 'getAttribute' => true, + 'lastInsertId' => true, + 'errorCode' => true, + 'errorInfo' => true, + 'getAttribute' => true, 'quote' => true, - '__wakeup' => true, + 'inTransaction' => true, + '__wakeup' => true, '__sleep' => true, 'getAvailableDrivers' => true, ); @@ -55,4 +56,4 @@ if (false == MySQLPDOTest::detect_transactional_mysql_engine($db)) print "done!"; --EXPECT-- -done! \ No newline at end of file +done!