From: Hirokazu Yamamoto <ocean-city@m2.ccsnet.ne.jp>
Date: Thu, 23 Oct 2008 00:38:15 +0000 (+0000)
Subject: Issue #4183: Some tests didn't run with pickle.HIGHEST_PROTOCOL.
X-Git-Tag: v3.0rc2~49
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d0d0b65885a25aa3d33502ee9b0e6f26d11f4531;p=python

Issue #4183: Some tests didn't run with pickle.HIGHEST_PROTOCOL.
Reviewed by Benjamin Peterson.
---

diff --git a/Lib/test/test_bytes.py b/Lib/test/test_bytes.py
index c3681437d5..c4a3e51ca6 100644
--- a/Lib/test/test_bytes.py
+++ b/Lib/test/test_bytes.py
@@ -397,7 +397,7 @@ class BaseBytesTest(unittest.TestCase):
         self.assertEqual(b.rpartition(b'i'), (b'mississipp', b'i', b''))
 
     def test_pickling(self):
-        for proto in range(pickle.HIGHEST_PROTOCOL):
+        for proto in range(pickle.HIGHEST_PROTOCOL + 1):
             for b in b"", b"a", b"abc", b"\xffab\x80", b"\0\0\377\0\0":
                 b = self.type2test(b)
                 ps = pickle.dumps(b, proto)
@@ -979,7 +979,7 @@ class ByteArraySubclassTest(unittest.TestCase):
         a = ByteArraySubclass(b"abcd")
         a.x = 10
         a.y = ByteArraySubclass(b"efgh")
-        for proto in range(pickle.HIGHEST_PROTOCOL):
+        for proto in range(pickle.HIGHEST_PROTOCOL + 1):
             b = pickle.loads(pickle.dumps(a, proto))
             self.assertNotEqual(id(a), id(b))
             self.assertEqual(a, b)
diff --git a/Lib/test/test_range.py b/Lib/test/test_range.py
index b14a22b42e..43fadf01d1 100644
--- a/Lib/test/test_range.py
+++ b/Lib/test/test_range.py
@@ -65,7 +65,7 @@ class RangeTest(unittest.TestCase):
     def test_pickling(self):
         testcases = [(13,), (0, 11), (-22, 10), (20, 3, -1),
                      (13, 21, 3), (-2, 2, 2)]
-        for proto in range(pickle.HIGHEST_PROTOCOL):
+        for proto in range(pickle.HIGHEST_PROTOCOL + 1):
             for t in testcases:
                 r = range(*t)
                 self.assertEquals(list(pickle.loads(pickle.dumps(r, proto))),