From: Stef Walter <stef@thewalter.net>
Date: Wed, 10 Jul 2013 13:22:00 +0000 (+0200)
Subject: Build with -fno-common to catch definition problems
X-Git-Tag: 0.19.2~20
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=d00f6b24e5349d8d37868b8f4451b1dc9b38767e;p=p11-kit

Build with -fno-common to catch definition problems

Fix some global variables not declared as extern

https://bugs.freedesktop.org/show_bug.cgi?id=66015
---

diff --git a/configure.ac b/configure.ac
index 5eb6c2c..b0bbbd5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -378,7 +378,7 @@ if test "$GCC" = "yes"; then
 		-Wmissing-prototypes -Wnested-externs -Wpointer-arith \
 		-Wdeclaration-after-statement -Wformat=2 -Winit-self \
 		-Waggregate-return -Wno-missing-format-attribute \
-		-fno-strict-aliasing"
+		-fno-strict-aliasing -fno-common"
 
 	for option in -Wmissing-include-dirs -Wundef; do
 		SAVE_CFLAGS="$CFLAGS"
diff --git a/p11-kit/virtual.h b/p11-kit/virtual.h
index f1fb676..d29ea49 100644
--- a/p11-kit/virtual.h
+++ b/p11-kit/virtual.h
@@ -45,9 +45,9 @@ typedef struct {
 	p11_destroyer lower_destroy;
 } p11_virtual;
 
-CK_X_FUNCTION_LIST      p11_virtual_base;
+extern CK_X_FUNCTION_LIST p11_virtual_base;
 
-CK_X_FUNCTION_LIST      p11_virtual_stack;
+extern CK_X_FUNCTION_LIST p11_virtual_stack;
 
 void                    p11_virtual_init       (p11_virtual *virt,
                                                 CK_X_FUNCTION_LIST *funcs,