From: Mark Dickinson <mdickinson@enthought.com>
Date: Mon, 7 May 2012 11:01:27 +0000 (+0100)
Subject: Issue #14701:  Add missing support for 'raise ... from' in parser module.
X-Git-Tag: v3.3.0a4~237^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cf360b92099d3ebcd31f637e45df501f393ff0b0;p=python

Issue #14701:  Add missing support for 'raise ... from' in parser module.
---

diff --git a/Lib/test/test_parser.py b/Lib/test/test_parser.py
index f6105fc818..edd1a09475 100644
--- a/Lib/test/test_parser.py
+++ b/Lib/test/test_parser.py
@@ -297,6 +297,14 @@ class RoundtripLegalSyntaxTestCase(unittest.TestCase):
         self.check_suite("[*a, *b] = y")
         self.check_suite("for [*x, b] in x: pass")
 
+    def test_raise_statement(self):
+        self.check_suite("raise\n")
+        self.check_suite("raise e\n")
+        self.check_suite("try:\n"
+                         "    suite\n"
+                         "except Exception as e:\n"
+                         "    raise ValueError from e\n")
+
 
 #
 #  Second, we take *invalid* trees and make sure we get ParserError
diff --git a/Misc/NEWS b/Misc/NEWS
index fe86680b3d..e777cac1a5 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -61,6 +61,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #14701: Fix missing support for 'raise ... from' in parser module.
+
 - Issue #13183: Fix pdb skipping frames after hitting a breakpoint and running
   step.  Patch by Xavier de Gaye.
 
diff --git a/Modules/parsermodule.c b/Modules/parsermodule.c
index 99e476d762..89ad9789ba 100644
--- a/Modules/parsermodule.c
+++ b/Modules/parsermodule.c
@@ -1608,31 +1608,30 @@ validate_return_stmt(node *tree)
 }
 
 
+/*
+ *  raise_stmt:
+ *
+ *  'raise' [test ['from' test]]
+ */
 static int
 validate_raise_stmt(node *tree)
 {
     int nch = NCH(tree);
     int res = (validate_ntype(tree, raise_stmt)
-               && ((nch == 1) || (nch == 2) || (nch == 4) || (nch == 6)));
+               && ((nch == 1) || (nch == 2) || (nch == 4)));
+
+    if (!res && !PyErr_Occurred())
+        (void) validate_numnodes(tree, 2, "raise");
 
     if (res) {
         res = validate_name(CHILD(tree, 0), "raise");
         if (res && (nch >= 2))
             res = validate_test(CHILD(tree, 1));
-        if (res && nch > 2) {
-            res = (validate_comma(CHILD(tree, 2))
+        if (res && (nch == 4)) {
+            res = (validate_name(CHILD(tree, 2), "from")
                    && validate_test(CHILD(tree, 3)));
-            if (res && (nch > 4))
-                res = (validate_comma(CHILD(tree, 4))
-                       && validate_test(CHILD(tree, 5)));
         }
     }
-    else
-        (void) validate_numnodes(tree, 2, "raise");
-    if (res && (nch == 4))
-        res = (validate_comma(CHILD(tree, 2))
-               && validate_test(CHILD(tree, 3)));
-
     return (res);
 }