From: Benjamin Peterson <benjamin@python.org>
Date: Wed, 12 Mar 2014 23:05:53 +0000 (-0500)
Subject: use ssl.PROTOCOL_SSLv23 for maximum compatibility (closes #20896)
X-Git-Tag: v3.3.6rc1~16^2~9
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cf25c5caae01b1e44793478df50456048e11f31b;p=python

use ssl.PROTOCOL_SSLv23 for maximum compatibility (closes #20896)
---

diff --git a/Lib/test/test_ssl.py b/Lib/test/test_ssl.py
index 4d67fa1de4..5c8df8bad8 100644
--- a/Lib/test/test_ssl.py
+++ b/Lib/test/test_ssl.py
@@ -690,12 +690,15 @@ class NetworkedTests(unittest.TestCase):
 
     def test_get_server_certificate(self):
         with support.transient_internet("svn.python.org"):
-            pem = ssl.get_server_certificate(("svn.python.org", 443))
+            pem = ssl.get_server_certificate(("svn.python.org", 443),
+                                             ssl.PROTOCOL_SSLv23)
             if not pem:
                 self.fail("No server certificate on svn.python.org:443!")
 
             try:
-                pem = ssl.get_server_certificate(("svn.python.org", 443), ca_certs=CERTFILE)
+                pem = ssl.get_server_certificate(("svn.python.org", 443),
+                                                 ssl.PROTOCOL_SSLv23,
+                                                 ca_certs=CERTFILE)
             except ssl.SSLError as x:
                 #should fail
                 if support.verbose:
@@ -703,7 +706,9 @@ class NetworkedTests(unittest.TestCase):
             else:
                 self.fail("Got server certificate %s for svn.python.org!" % pem)
 
-            pem = ssl.get_server_certificate(("svn.python.org", 443), ca_certs=SVN_PYTHON_ORG_ROOT_CERT)
+            pem = ssl.get_server_certificate(("svn.python.org", 443),
+                                             ssl.PROTOCOL_SSLv23,
+                                             ca_certs=SVN_PYTHON_ORG_ROOT_CERT)
             if not pem:
                 self.fail("No server certificate on svn.python.org:443!")
             if support.verbose: