From: Benjamin Peterson <benjamin@python.org>
Date: Sat, 25 Nov 2017 21:02:55 +0000 (-0800)
Subject: mark fatal_error as noreturn (#4563)
X-Git-Tag: v3.7.0a3~87
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cef88b9c15cf387cf6a39a387a6868883409df4f;p=python

mark fatal_error as noreturn (#4563)

clang can't figure out that fatal_error is noreturn itself and emits warnings:

../cpython/Python/pylifecycle.c:2116:1: warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
}
^
../cpython/Python/pylifecycle.c:2125:1: warning: function declared 'noreturn' should not return [-Winvalid-noreturn]
}
^
---

diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
index 868ac8450d..b89cbc88d4 100644
--- a/Python/pylifecycle.c
+++ b/Python/pylifecycle.c
@@ -2048,7 +2048,7 @@ fatal_output_debug(const char *msg)
 }
 #endif
 
-static void
+static void _Py_NO_RETURN
 fatal_error(const char *prefix, const char *msg, int status)
 {
     const int fd = fileno(stderr);