From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Mon, 21 May 2018 04:32:28 +0000 (-0400)
Subject: Fix unsafe usage of strerror(errno) within ereport().
X-Git-Tag: REL9_5_14~68
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ced0cdc76cfc09eaa722e79fe9720729703da2ce;p=postgresql

Fix unsafe usage of strerror(errno) within ereport().

This is the converse of the unsafe-usage-of-%m problem: the reason
ereport/elog provide that format code is mainly to dodge the hazard
of errno getting changed before control reaches functions within the
arguments of the macro.  I only found one instance of this hazard,
but it's been there since 9.4 :-(.
---

diff --git a/src/backend/libpq/auth.c b/src/backend/libpq/auth.c
index 8fb518dbc2..c3339b0ce7 100644
--- a/src/backend/libpq/auth.c
+++ b/src/backend/libpq/auth.c
@@ -1620,10 +1620,12 @@ auth_peer(hbaPort *port)
 	pw = getpwuid(uid);
 	if (!pw)
 	{
+		int			save_errno = errno;
+
 		ereport(LOG,
 				(errmsg("could not look up local user ID %ld: %s",
 						(long) uid,
-						errno ? strerror(errno) : _("user does not exist"))));
+						save_errno ? strerror(save_errno) : _("user does not exist"))));
 		return STATUS_ERROR;
 	}