From: Pierre Joye <pajoye@php.net>
Date: Sun, 30 Aug 2009 17:13:45 +0000 (+0000)
Subject: - Fixed leak on error in popen/exec (and related functions)
X-Git-Tag: php-5.3.1RC1~25
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ceb607af13c370bb30b6bbbd8adde6e053eb7008;p=php

- Fixed leak on error in popen/exec (and related functions)
---

diff --git a/NEWS b/NEWS
index 93db3f8793..cc6f70a974 100644
--- a/NEWS
+++ b/NEWS
@@ -16,6 +16,8 @@ PHP                                                                        NEWS
 - Improved shared extension loading on OSX to use the standard Unix dlopen()
   API. (Scott)
 
+- Fixed leak on error in popen/exec (and related functions) on Windows.
+  (Pierre)
 - Fixed possible bad caching of symlinked directories in the realpath cache
   on Windows. (Pierre)
 - Fixed atime and mtime in stat related functions on Windows. (Pierre)
diff --git a/TSRM/tsrm_win32.c b/TSRM/tsrm_win32.c
index b2e94d22af..19139dd7ae 100644
--- a/TSRM/tsrm_win32.c
+++ b/TSRM/tsrm_win32.c
@@ -371,6 +371,7 @@ TSRM_API FILE *popen_ex(const char *command, const char *type, const char *cwd,
 	sprintf(cmd, "%s /c \"%s\"", TWG(comspec), command);
 
 	if (!CreateProcess(NULL, cmd, &security, &security, security.bInheritHandle, dwCreateFlags, env, cwd, &startup, &process)) {
+		free(cmd);
 		return NULL;
 	}
 	free(cmd);