From: Martin v. Löwis <martin@v.loewis.de>
Date: Sat, 18 Nov 2006 18:00:34 +0000 (+0000)
Subject: Patch #1538878: Don't make tkSimpleDialog dialogs transient if
X-Git-Tag: v2.5.1c1~247
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ce9212f018fbd074aba7a37cef4291ebd2e428d4;p=python

Patch #1538878: Don't make tkSimpleDialog dialogs transient if
the parent window is withdrawn. This mirrors what dialog.tcl
does.
---

diff --git a/Lib/lib-tk/tkSimpleDialog.py b/Lib/lib-tk/tkSimpleDialog.py
index 4d11ce0209..02ea034b33 100644
--- a/Lib/lib-tk/tkSimpleDialog.py
+++ b/Lib/lib-tk/tkSimpleDialog.py
@@ -46,8 +46,13 @@ class Dialog(Toplevel):
             title -- the dialog title
         '''
         Toplevel.__init__(self, parent)
-        self.transient(parent)
 
+        # If the master is not viewable, don't
+        # make the child transient, or else it
+        # would be opened withdrawn
+        if parent.winfo_viewable():  
+            self.transient(parent)
+ 
         if title:
             self.title(title)
 
diff --git a/Misc/NEWS b/Misc/NEWS
index 8324a055ac..6e50ed3c7b 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -103,6 +103,9 @@ Extension Modules
 Library
 -------
 
+- Patch #1538878: Don't make tkSimpleDialog dialogs transient if
+  the parent window is withdrawn.
+
 - Patch #1360200: Use unmangled_version RPM spec field to deal with
   file name mangling.