From: Tom Lane Date: Mon, 29 May 2017 19:19:07 +0000 (-0400) Subject: Allow NumericOnly to be "+ FCONST". X-Git-Tag: REL_10_BETA2~271 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ce509452955487c9e11d042b6a564c76600334db;p=postgresql Allow NumericOnly to be "+ FCONST". The NumericOnly grammar production accepted ICONST, + ICONST, - ICONST, FCONST, and - FCONST, but for some reason not + FCONST. This led to strange inconsistencies like regression=# set random_page_cost = +4; SET regression=# set random_page_cost = 4000000000; SET regression=# set random_page_cost = +4000000000; ERROR: syntax error at or near "4000000000" (because 4000000000 is too large to be an ICONST). While there's no actual functional reason to need to write a "+", if we allow it for integers it seems like we should allow it for numerics too. It's been like that forever, so back-patch to all supported branches. Discussion: https://postgr.es/m/30908.1496006184@sss.pgh.pa.us --- diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y index ff5b1becf2..7e03624eb4 100644 --- a/src/backend/parser/gram.y +++ b/src/backend/parser/gram.y @@ -4121,6 +4121,7 @@ opt_by: BY {} NumericOnly: FCONST { $$ = makeFloat($1); } + | '+' FCONST { $$ = makeFloat($2); } | '-' FCONST { $$ = makeFloat($2);