From: Alexander Kornienko Date: Wed, 5 Mar 2014 10:38:27 +0000 (+0000) Subject: Added a const qualifier to SourceManager& parameters. X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cde007b55d1c221100385230db9b07a018b59c45;p=clang Added a const qualifier to SourceManager& parameters. git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@202964 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/include/clang/Tooling/Refactoring.h b/include/clang/Tooling/Refactoring.h index 43ec9acdb3..cd2fb9f6c5 100644 --- a/include/clang/Tooling/Refactoring.h +++ b/include/clang/Tooling/Refactoring.h @@ -83,16 +83,16 @@ public: /// \brief Creates a Replacement of the range [Start, Start+Length) with /// ReplacementText. - Replacement(SourceManager &Sources, SourceLocation Start, unsigned Length, + Replacement(const SourceManager &Sources, SourceLocation Start, unsigned Length, StringRef ReplacementText); /// \brief Creates a Replacement of the given range with ReplacementText. - Replacement(SourceManager &Sources, const CharSourceRange &Range, + Replacement(const SourceManager &Sources, const CharSourceRange &Range, StringRef ReplacementText); /// \brief Creates a Replacement of the node with ReplacementText. template - Replacement(SourceManager &Sources, const Node &NodeToReplace, + Replacement(const SourceManager &Sources, const Node &NodeToReplace, StringRef ReplacementText); /// \brief Returns whether this replacement can be applied to a file. @@ -115,9 +115,10 @@ public: std::string toString() const; private: - void setFromSourceLocation(SourceManager &Sources, SourceLocation Start, + void setFromSourceLocation(const SourceManager &Sources, SourceLocation Start, unsigned Length, StringRef ReplacementText); - void setFromSourceRange(SourceManager &Sources, const CharSourceRange &Range, + void setFromSourceRange(const SourceManager &Sources, + const CharSourceRange &Range, StringRef ReplacementText); std::string FilePath; @@ -230,8 +231,8 @@ private: }; template -Replacement::Replacement(SourceManager &Sources, const Node &NodeToReplace, - StringRef ReplacementText) { +Replacement::Replacement(const SourceManager &Sources, + const Node &NodeToReplace, StringRef ReplacementText) { const CharSourceRange Range = CharSourceRange::getTokenRange(NodeToReplace->getSourceRange()); setFromSourceRange(Sources, Range, ReplacementText); diff --git a/lib/Tooling/Refactoring.cpp b/lib/Tooling/Refactoring.cpp index 4535366871..df9600e78c 100644 --- a/lib/Tooling/Refactoring.cpp +++ b/lib/Tooling/Refactoring.cpp @@ -35,12 +35,13 @@ Replacement::Replacement(StringRef FilePath, unsigned Offset, unsigned Length, : FilePath(FilePath), ReplacementRange(Offset, Length), ReplacementText(ReplacementText) {} -Replacement::Replacement(SourceManager &Sources, SourceLocation Start, +Replacement::Replacement(const SourceManager &Sources, SourceLocation Start, unsigned Length, StringRef ReplacementText) { setFromSourceLocation(Sources, Start, Length, ReplacementText); } -Replacement::Replacement(SourceManager &Sources, const CharSourceRange &Range, +Replacement::Replacement(const SourceManager &Sources, + const CharSourceRange &Range, StringRef ReplacementText) { setFromSourceRange(Sources, Range, ReplacementText); } @@ -99,7 +100,7 @@ bool operator==(const Replacement &LHS, const Replacement &RHS) { LHS.getReplacementText() == RHS.getReplacementText(); } -void Replacement::setFromSourceLocation(SourceManager &Sources, +void Replacement::setFromSourceLocation(const SourceManager &Sources, SourceLocation Start, unsigned Length, StringRef ReplacementText) { const std::pair DecomposedLocation = @@ -121,7 +122,8 @@ void Replacement::setFromSourceLocation(SourceManager &Sources, // FIXME: This should go into the Lexer, but we need to figure out how // to handle ranges for refactoring in general first - there is no obvious // good way how to integrate this into the Lexer yet. -static int getRangeSize(SourceManager &Sources, const CharSourceRange &Range) { +static int getRangeSize(const SourceManager &Sources, + const CharSourceRange &Range) { SourceLocation SpellingBegin = Sources.getSpellingLoc(Range.getBegin()); SourceLocation SpellingEnd = Sources.getSpellingLoc(Range.getEnd()); std::pair Start = Sources.getDecomposedLoc(SpellingBegin); @@ -133,7 +135,7 @@ static int getRangeSize(SourceManager &Sources, const CharSourceRange &Range) { return End.second - Start.second; } -void Replacement::setFromSourceRange(SourceManager &Sources, +void Replacement::setFromSourceRange(const SourceManager &Sources, const CharSourceRange &Range, StringRef ReplacementText) { setFromSourceLocation(Sources, Sources.getSpellingLoc(Range.getBegin()),