From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Wed, 21 Dec 2022 05:07:47 +0000 (-0800)
Subject: smyrna new_attr_ref: remove shadowing of global 'attr'
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cdd8c6b34761081e784e79ad5d0bc47e0f4c74df;p=graphviz

smyrna new_attr_ref: remove shadowing of global 'attr'
---

diff --git a/cmd/smyrna/gui/frmobjectui.c b/cmd/smyrna/gui/frmobjectui.c
index 0cd6cd145..67093b5a8 100644
--- a/cmd/smyrna/gui/frmobjectui.c
+++ b/cmd/smyrna/gui/frmobjectui.c
@@ -100,15 +100,15 @@ static attr_t *new_attr_with_ref(Agsym_t * sym)
 
 static attr_t *new_attr_ref(attr_t * refAttr)
 {
-    attr_t *attr = gv_alloc(sizeof(attr_t));
-    *attr = *refAttr;
-    attr->defValG = safestrdup(refAttr->defValG);
-    attr->defValN = safestrdup(refAttr->defValN);
-    attr->defValE = safestrdup(refAttr->defValE);
-    attr->name = safestrdup(refAttr->name);
+    attr_t *a = gv_alloc(sizeof(attr_t));
+    *a = *refAttr;
+    a->defValG = safestrdup(refAttr->defValG);
+    a->defValN = safestrdup(refAttr->defValN);
+    a->defValE = safestrdup(refAttr->defValE);
+    a->name = safestrdup(refAttr->name);
     if (refAttr->value)
-	attr->value = safestrdup(refAttr->value);
-    return attr;
+	a->value = safestrdup(refAttr->value);
+    return a;
 }
 
 static void reset_attr_list_widgets(attr_list * l)