From: Raymond Hettinger <python@rcn.com>
Date: Wed, 7 Nov 2007 02:26:17 +0000 (+0000)
Subject: Optimize dict.fromkeys() with dict inputs.  Useful for resetting bag/muliset counts... 
X-Git-Tag: v2.6a1~1083
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cdcf887999524cb7ff5ba3cab129d04956333e0d;p=python

Optimize dict.fromkeys() with dict inputs.  Useful for resetting bag/muliset counts for example.
---

diff --git a/Lib/test/test_dict.py b/Lib/test/test_dict.py
index 7f0aabb20a..9f049ad41a 100644
--- a/Lib/test/test_dict.py
+++ b/Lib/test/test_dict.py
@@ -243,6 +243,10 @@ class DictTest(unittest.TestCase):
 
         self.assertRaises(Exc, baddict2.fromkeys, [1])
 
+        # test fast path for dictionary inputs
+        d = dict(zip(range(6), range(6)))
+        self.assertEqual(dict.fromkeys(d, 0), dict(zip(range(6), [0]*6)))
+
     def test_copy(self):
         d = {1:1, 2:2, 3:3}
         self.assertEqual(d.copy(), {1:1, 2:2, 3:3})
diff --git a/Objects/dictobject.c b/Objects/dictobject.c
index 9b99bbf46e..00f9bc8b2f 100644
--- a/Objects/dictobject.c
+++ b/Objects/dictobject.c
@@ -1184,6 +1184,25 @@ dict_fromkeys(PyObject *cls, PyObject *args)
 	if (d == NULL)
 		return NULL;
 
+	if (PyDict_CheckExact(d) && PyDict_CheckExact(seq)) {
+		PyDictObject *mp = (PyDictObject *)d;
+		PyObject *oldvalue;
+		Py_ssize_t pos = 0;
+		PyObject *key;
+		long hash;
+
+		if (dictresize(mp, ((PyDictObject *)seq)->ma_used))
+			return NULL;
+
+		while (_PyDict_Next(seq, &pos, &key, &oldvalue, &hash)) {
+			Py_INCREF(key);
+			Py_INCREF(value);
+			if (insertdict(mp, key, hash, value))
+				return NULL;
+		}
+		return d;
+	}
+
 	if (PyDict_CheckExact(d) && PyAnySet_CheckExact(seq)) {
 		PyDictObject *mp = (PyDictObject *)d;
 		Py_ssize_t pos = 0;