From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Tue, 12 Sep 2000 16:48:55 +0000 (+0000)
Subject: Remove incorrect extra heap_close when deleting a builtin function.
X-Git-Tag: REL7_1_BETA~681
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cdc7170ebe45f4eec35791a73f75b43f606b8fb1;p=postgresql

Remove incorrect extra heap_close when deleting a builtin function.
---

diff --git a/src/backend/commands/remove.c b/src/backend/commands/remove.c
index f0958ab393..c5b7968e5f 100644
--- a/src/backend/commands/remove.c
+++ b/src/backend/commands/remove.c
@@ -8,7 +8,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/Attic/remove.c,v 1.51 2000/09/06 14:15:16 petere Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/Attic/remove.c,v 1.52 2000/09/12 16:48:55 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -356,15 +356,12 @@ RemoveFunction(char *functionName,		/* function name to be removed */
 							  0);
 
 	if (!HeapTupleIsValid(tup))
-	{
-		heap_close(relation, RowExclusiveLock);
 		func_error("RemoveFunction", functionName, nargs, argList, NULL);
-	}
 
 	if (((Form_pg_proc) GETSTRUCT(tup))->prolang == INTERNALlanguageId ||
 		((Form_pg_proc) GETSTRUCT(tup))->prolang == NEWINTERNALlanguageId)
 	{
-		heap_close(relation, RowExclusiveLock);
+		/* "Helpful" notice when removing a builtin function ... */
 		elog(NOTICE, "Removing built-in function \"%s\"", functionName);
 	}