From: Christophe Jaillet <jailletc36@apache.org>
Date: Thu, 24 May 2018 20:36:26 +0000 (+0000)
Subject: Success of 'SHGetMalloc()' should be tested with the SUCCEEDED macro.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cda22a05144b23fe37347e1cd540cba944f8b303;p=apache

Success of 'SHGetMalloc()' should be tested with the SUCCEEDED macro.

/!\   This commit is _NOT COMPILE TESTED_. (I don't have a windows build environment available)

See PR 60086.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1832198 13f79535-47bb-0310-9956-ffa450edef68
---

diff --git a/support/win32/ApacheMonitor.c b/support/win32/ApacheMonitor.c
index 26b54a00db..841b4ab236 100644
--- a/support/win32/ApacheMonitor.c
+++ b/support/win32/ApacheMonitor.c
@@ -912,7 +912,7 @@ LRESULT CALLBACK ConnectDlgProc(HWND hDlg, UINT message,
                             WM_SETTEXT,
                             (WPARAM) NULL, (LPARAM) szCmp);
             }
-            if (SHGetMalloc(&pMalloc)) {
+            if (SUCCEEDED(SHGetMalloc(&pMalloc))) {
                 pMalloc->lpVtbl->Free(pMalloc, il);
                 pMalloc->lpVtbl->Release(pMalloc);
             }