From: Kevin McCarthy <kevin@8t8.us>
Date: Sun, 26 May 2019 23:03:40 +0000 (-0700)
Subject: Change mutt_addr_is_user() to no for a NULL address.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cd30526c45ef8b5075b0f08603136ac64ab295b4;p=mutt

Change mutt_addr_is_user() to no for a NULL address.

See ticket #140.

The behavior is generating a false 'F' flag for a spam message with an
unparsable From address.

After reviewing the callers, I can't see a reason returning 'yes' in
this case.

Commit 690c2945 fixed a potential segv issue, but the other callers
seem robust against this change in behavior.
---

diff --git a/alias.c b/alias.c
index 0b37fbcc..593d5d99 100644
--- a/alias.c
+++ b/alias.c
@@ -614,11 +614,10 @@ int mutt_addr_is_user (ADDRESS *addr)
 {
   const char *fqdn;
 
-  /* NULL address is assumed to be the user. */
   if (!addr)
   {
-    dprint (5, (debugfile, "mutt_addr_is_user: yes, NULL address\n"));
-    return 1;
+    dprint (5, (debugfile, "mutt_addr_is_user: no, NULL address\n"));
+    return 0;
   }
   if (!addr->mailbox)
   {