From: Nicolas François <nicolas.francois@centraliens.net>
Date: Tue, 13 Aug 2013 21:57:14 +0000 (+0200)
Subject: Add schematics with ranges to help reviews.
X-Git-Tag: 4.2.1~21
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cd1bd8bf4ca936dc5af8b51648061e4e23949501;p=shadow

Add schematics with ranges to help reviews.

	* lib/subordinateio.c: Add schematics with ranges to help reviews.
---

diff --git a/ChangeLog b/ChangeLog
index ed54e121..0b87be1f 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,7 @@
 2013-08-13  Nicolas François  <nicolas.francois@centraliens.net>
 
 	* lib/subordinateio.c: Avoid dead branches.
+	* lib/subordinateio.c: Add schematics with ranges to help reviews.
 
 2013-08-13  Nicolas François  <nicolas.francois@centraliens.net>
 
diff --git a/lib/subordinateio.c b/lib/subordinateio.c
index 25a2d304..7811eb85 100644
--- a/lib/subordinateio.c
+++ b/lib/subordinateio.c
@@ -311,10 +311,14 @@ static int remove_range(struct commonio_db *db,
 
 		if (start <= first) {
 			if (end >= last) {
+				/* to be removed: [start,      end]
+				 * range:           [first, last] */
 				/* entry completely contained in the
 				 * range to remove */
 				commonio_del_entry (db, ent);
 			} else {
+				/* to be removed: [start,  end]
+				 * range:           [first, last] */
 				/* Remove only the start of the entry */
 				range->start = end + 1;
 				range->count = (last - range->start) + 1;
@@ -324,12 +328,16 @@ static int remove_range(struct commonio_db *db,
 			}
 		} else {
 			if (end >= last) {
+				/* to be removed:   [start,  end]
+				 * range:         [first, last] */
 				/* Remove only the end of the entry */
 				range->count = start - range->start;
 
 				ent->changed = true;
 				db->changed = true;
 			} else {
+				/* to be removed:   [start, end]
+				 * range:         [first,    last] */
 				/* Remove the middle of the range
 				 * This requires to create a new range */
 				struct subordinate_range tail;