From: Nico Weber <nicolasweber@gmx.de>
Date: Sun, 21 Apr 2019 20:08:45 +0000 (+0000)
Subject: gn build: Merge r358749
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ccf549467d192a2c1d0c39e3507e7601c46eb923;p=llvm

gn build: Merge r358749

Since the symlinks list for llvm-symbolizer is now never empty,
the :symlinks target no longer needs an explicit dep on :llvm-symbolizer
-- there will be at least one dep on a symlink, and each symlink depends
on :llvm-symbolizer already.

Since llvm-symbolizer:symlinks now produces symlinks that check-llvm
uses, make llvm/test depend on the symlink target.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@358861 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/utils/gn/secondary/llvm/test/BUILD.gn b/utils/gn/secondary/llvm/test/BUILD.gn
index 25e8ca43e35..c8871e0400b 100644
--- a/utils/gn/secondary/llvm/test/BUILD.gn
+++ b/utils/gn/secondary/llvm/test/BUILD.gn
@@ -227,7 +227,7 @@ group("test") {
     "//llvm/tools/llvm-size",
     "//llvm/tools/llvm-split",
     "//llvm/tools/llvm-strings",
-    "//llvm/tools/llvm-symbolizer",
+    "//llvm/tools/llvm-symbolizer:symlinks",
     "//llvm/tools/llvm-undname",
     "//llvm/tools/llvm-xray",
     "//llvm/tools/lto",
diff --git a/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn b/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn
index e567a70d0a8..2b1b0917e76 100644
--- a/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn
+++ b/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn
@@ -11,7 +11,7 @@ if (llvm_install_binutils_symlinks) {
   }
 }
 
-# //:llvm-nm depends on this symlink target, see comment in //BUILD.gn.
+# //:llvm-objdump depends on this symlink target, see comment in //BUILD.gn.
 group("symlinks") {
   deps = [
     ":llvm-objdump",
diff --git a/utils/gn/secondary/llvm/tools/llvm-symbolizer/BUILD.gn b/utils/gn/secondary/llvm/tools/llvm-symbolizer/BUILD.gn
index 497d2c8284b..34e4e41b9c8 100644
--- a/utils/gn/secondary/llvm/tools/llvm-symbolizer/BUILD.gn
+++ b/utils/gn/secondary/llvm/tools/llvm-symbolizer/BUILD.gn
@@ -1,23 +1,25 @@
 import("//llvm/tools/binutils_symlinks.gni")
 import("//llvm/utils/gn/build/symlink_or_copy.gni")
 
+symlinks = [ "llvm-addr2line" ]
 if (llvm_install_binutils_symlinks) {
-  symlink_or_copy("addr2line") {
+  symlinks += [ "addr2line" ]
+}
+foreach(target, symlinks) {
+  symlink_or_copy(target) {
     deps = [
       ":llvm-symbolizer",
     ]
     source = "llvm-symbolizer"
-    output = "$root_out_dir/bin/addr2line"
+    output = "$root_out_dir/bin/$target"
   }
 }
 
 # //:llvm-symbolizer depends on this symlink target, see comment in //BUILD.gn.
 group("symlinks") {
-  deps = [
-    ":llvm-symbolizer",
-  ]
-  if (llvm_install_binutils_symlinks) {
-    deps += [ ":addr2line" ]
+  deps = []
+  foreach(target, symlinks) {
+    deps += [ ":$target" ]
   }
 }