From: Todd C. Miller Date: Sat, 15 Mar 2003 01:11:26 +0000 (+0000) Subject: use strlcpy, not strncpy X-Git-Tag: SUDO_1_6_7~41 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cc5cc07652e303f33158c44180efad2a33811ac3;p=sudo use strlcpy, not strncpy --- diff --git a/parse.lex b/parse.lex index d355ea13d..dde434729 100644 --- a/parse.lex +++ b/parse.lex @@ -387,15 +387,14 @@ fill_cmnd(s, len) { arg_len = arg_size = 0; - yylval.command.cmnd = (char *) malloc(len + 1); + yylval.command.cmnd = (char *) malloc(++len); if (yylval.command.cmnd == NULL) { yyerror("unable to allocate memory"); return; } /* copy the string and NULL-terminate it (escapes handled by fnmatch) */ - (void) strncpy(yylval.command.cmnd, s, len); - yylval.command.cmnd[len] = '\0'; + (void) strlcpy(yylval.command.cmnd, s, len); yylval.command.args = NULL; }