From: Mark Dickinson <dickinsm@gmail.com>
Date: Sun, 4 Jul 2010 10:15:11 +0000 (+0000)
Subject: Fix refleak in Modules/audioop.c.
X-Git-Tag: v3.2a1~327
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cc588c1d37448895f8f98b424c0e51b23c0ae783;p=python

Fix refleak in Modules/audioop.c.
---

diff --git a/Modules/audioop.c b/Modules/audioop.c
index 66f1f1f36a..38e3e7ace2 100644
--- a/Modules/audioop.c
+++ b/Modules/audioop.c
@@ -807,10 +807,13 @@ audioop_tomono(PyObject *self, PyObject *args)
         return 0;
     cp = pcp.buf;
     len = pcp.len;
-    if (!audioop_check_parameters(len, size))
+    if (!audioop_check_parameters(len, size)) {
+        PyBuffer_Release(&pcp);
         return NULL;
+    }
     if (((len / size) & 1) != 0) {
         PyErr_SetString(AudioopError, "not a whole number of frames");
+        PyBuffer_Release(&pcp);
         return NULL;
     }
 
@@ -824,8 +827,10 @@ audioop_tomono(PyObject *self, PyObject *args)
     }
 
     rv = PyBytes_FromStringAndSize(NULL, len/2);
-    if ( rv == 0 )
+    if ( rv == 0 ) {
+        PyBuffer_Release(&pcp);
         return 0;
+    }
     ncp = (signed char *)PyBytes_AsString(rv);