From: Matt Caswell <matt@openssl.org>
Date: Thu, 25 Aug 2016 08:40:17 +0000 (+0100)
Subject: Fix an uninitialised read on an error path
X-Git-Tag: OpenSSL_1_1_0~6
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cc069067075d77c7a61e44a253aec917d0b6a2f5;p=openssl

Fix an uninitialised read on an error path

Found by Coverity.

Reviewed-by: Richard Levitte <levitte@openssl.org>
---

diff --git a/crypto/ocsp/ocsp_ext.c b/crypto/ocsp/ocsp_ext.c
index 72d21796d2..b829b2e4e3 100644
--- a/crypto/ocsp/ocsp_ext.c
+++ b/crypto/ocsp/ocsp_ext.c
@@ -257,7 +257,7 @@ static int ocsp_add1_nonce(STACK_OF(X509_EXTENSION) **exts,
      */
     os.length = ASN1_object_size(0, len, V_ASN1_OCTET_STRING);
     if (os.length < 0)
-        goto err;
+        return 0;
 
     os.data = OPENSSL_malloc(os.length);
     if (os.data == NULL)