From: Christian Heimes Date: Wed, 5 Dec 2007 20:10:38 +0000 (+0000) Subject: Fixed bug #1557 by using popen.communicate() before popen.wait() X-Git-Tag: v2.6a1~922 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cbdb705c887fb9c7feaa83ad93c365448926b110;p=python Fixed bug #1557 by using popen.communicate() before popen.wait() --- diff --git a/Lib/distutils/msvc9compiler.py b/Lib/distutils/msvc9compiler.py index a6cff2c04e..828d7fbf7a 100644 --- a/Lib/distutils/msvc9compiler.py +++ b/Lib/distutils/msvc9compiler.py @@ -254,10 +254,13 @@ def query_vcvarsall(version, arch="x86"): popen = subprocess.Popen('"%s" %s & set' % (vcvarsall, arch), stdout=subprocess.PIPE, stderr=subprocess.PIPE) + + stdout, stderr = popen.communicate() if popen.wait() != 0: - raise IOError(popen.stderr.read()) + raise IOError(stderr.decode("mbcs")) - for line in popen.stdout: + stdout = stdout.decode("mbcs") + for line in stdout.split("\n"): line = Reg.convert_mbcs(line) if '=' not in line: continue