From: Serhiy Storchaka <storchaka@gmail.com>
Date: Mon, 30 Nov 2015 15:20:02 +0000 (+0200)
Subject: Issue #25718: Fixed copying object with state with boolean value is false.
X-Git-Tag: v3.4.4rc1~15
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cbbec1c53f4b6fb88b4ae984e69db2d2951cd560;p=python

Issue #25718: Fixed copying object with state with boolean value is false.
---

diff --git a/Lib/copy.py b/Lib/copy.py
index bb8840ed54..f0fb443777 100644
--- a/Lib/copy.py
+++ b/Lib/copy.py
@@ -281,7 +281,7 @@ def _reconstruct(x, info, deep, memo=None):
     if n > 2:
         state = info[2]
     else:
-        state = {}
+        state = None
     if n > 3:
         listiter = info[3]
     else:
@@ -295,7 +295,7 @@ def _reconstruct(x, info, deep, memo=None):
     y = callable(*args)
     memo[id(x)] = y
 
-    if state:
+    if state is not None:
         if deep:
             state = deepcopy(state, memo)
         if hasattr(y, '__setstate__'):
diff --git a/Lib/test/test_copy.py b/Lib/test/test_copy.py
index eb8d18cf0b..0c5354c65c 100644
--- a/Lib/test/test_copy.py
+++ b/Lib/test/test_copy.py
@@ -180,6 +180,9 @@ class TestCopy(unittest.TestCase):
                 return self.foo == other.foo
         x = C(42)
         self.assertEqual(copy.copy(x), x)
+        # State with boolean value is false (issue #25718)
+        x = C(0.0)
+        self.assertEqual(copy.copy(x), x)
 
     # The deepcopy() method
 
@@ -448,6 +451,12 @@ class TestCopy(unittest.TestCase):
         self.assertEqual(y, x)
         self.assertIsNot(y, x)
         self.assertIsNot(y.foo, x.foo)
+        # State with boolean value is false (issue #25718)
+        x = C([])
+        y = copy.deepcopy(x)
+        self.assertEqual(y, x)
+        self.assertIsNot(y, x)
+        self.assertIsNot(y.foo, x.foo)
 
     def test_deepcopy_reflexive_inst(self):
         class C:
diff --git a/Misc/NEWS b/Misc/NEWS
index 95f2626f26..c7a13948a3 100644
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -113,6 +113,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #25718: Fixed copying object with state with boolean value is false.
+
 - Issue #10131: Fixed deep copying of minidom documents.  Based on patch
   by Marian Ganisin.