From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Wed, 26 Nov 2008 16:23:11 +0000 (+0000)
Subject: Tweak new PQExpBufferBroken macro to suppress warnings from pickier
X-Git-Tag: REL8_4_BETA1~630
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cbb3e1cda7b6d571d5fe1501495f4ed8fb8ab965;p=postgresql

Tweak new PQExpBufferBroken macro to suppress warnings from pickier
versions of gcc.
---

diff --git a/src/interfaces/libpq/pqexpbuffer.h b/src/interfaces/libpq/pqexpbuffer.h
index 3acca24b56..8e7a907d0b 100644
--- a/src/interfaces/libpq/pqexpbuffer.h
+++ b/src/interfaces/libpq/pqexpbuffer.h
@@ -18,7 +18,7 @@
  * Portions Copyright (c) 1996-2008, PostgreSQL Global Development Group
  * Portions Copyright (c) 1994, Regents of the University of California
  *
- * $PostgreSQL: pgsql/src/interfaces/libpq/pqexpbuffer.h,v 1.20 2008/11/26 00:26:23 tgl Exp $
+ * $PostgreSQL: pgsql/src/interfaces/libpq/pqexpbuffer.h,v 1.21 2008/11/26 16:23:11 tgl Exp $
  *
  *-------------------------------------------------------------------------
  */
@@ -57,7 +57,7 @@ typedef PQExpBufferData *PQExpBuffer;
  *------------------------
  */
 #define PQExpBufferBroken(str)  \
-	(!(str) || (str)->maxlen == 0)
+	((str) == NULL || (str)->maxlen == 0)
 
 /*------------------------
  * Initial size of the data buffer in a PQExpBuffer.