From: Miss Islington (bot) <31488909+miss-islington@users.noreply.github.com>
Date: Tue, 10 Jul 2018 10:13:06 +0000 (-0700)
Subject: bpo-34031: fix incorrect usage of self.fail in two tests (GH-8091)
X-Git-Tag: v3.6.7rc1~185
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cb14eb7eedf36cd21aaf41c4d3eb1e6521fa7b11;p=python

bpo-34031: fix incorrect usage of self.fail in two tests (GH-8091)


Contributed by Bradley Laney.
(cherry picked from commit 6b490b5db40fc29588e8e6cc23bb89c4fed74ad5)

Co-authored-by: Bradley Laney <bradley.laney@gmail.com>
---

diff --git a/Lib/test/test_file.py b/Lib/test/test_file.py
index 9890b8c586..f58d1dae60 100644
--- a/Lib/test/test_file.py
+++ b/Lib/test/test_file.py
@@ -241,8 +241,7 @@ class OtherFileTests:
         # Test for appropriate errors mixing read* and iteration
         for methodname, args in methods:
             f = self.open(TESTFN, 'rb')
-            if next(f) != filler:
-                self.fail, "Broken testfile"
+            self.assertEqual(next(f), filler)
             meth = getattr(f, methodname)
             meth(*args)  # This simply shouldn't fail
             f.close()
diff --git a/Lib/test/test_urllib2_localnet.py b/Lib/test/test_urllib2_localnet.py
index 9d9ec8726d..ef0091c493 100644
--- a/Lib/test/test_urllib2_localnet.py
+++ b/Lib/test/test_urllib2_localnet.py
@@ -308,7 +308,7 @@ class BasicAuthTests(unittest.TestCase):
         try:
             self.assertTrue(urllib.request.urlopen(self.server_url))
         except urllib.error.HTTPError:
-            self.fail("Basic auth failed for the url: %s", self.server_url)
+            self.fail("Basic auth failed for the url: %s" % self.server_url)
 
     def test_basic_auth_httperror(self):
         ah = urllib.request.HTTPBasicAuthHandler()