From: Georg Brandl <georg@python.org>
Date: Thu, 6 Apr 2006 10:03:32 +0000 (+0000)
Subject: Bug #1465600: note encoding issue in ZipFile.write().
X-Git-Tag: v2.5a2~406
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=caf9539b2b92094237b7aac4ddbafba35c58fbc1;p=python

Bug #1465600: note encoding issue in ZipFile.write().
---

diff --git a/Doc/lib/libzipfile.tex b/Doc/lib/libzipfile.tex
index 32ca3e02a4..4e06ef692e 100644
--- a/Doc/lib/libzipfile.tex
+++ b/Doc/lib/libzipfile.tex
@@ -141,10 +141,17 @@ cat myzip.zip >> python.exe
   Write the file named \var{filename} to the archive, giving it the
   archive name \var{arcname} (by default, this will be the same as
   \var{filename}, but without a drive letter and with leading path
-  separators removed).  If given, \var{compress_type} overrides the value
-  given for the \var{compression} parameter to the constructor for
-  the new entry.  The archive must be open with mode \code{'w'} or
-  \code{'a'}.
+  separators removed).  If given, \var{compress_type} overrides the
+  value given for the \var{compression} parameter to the constructor
+  for the new entry.  The archive must be open with mode \code{'w'}
+  or \code{'a'}.
+  
+  \note{There is no official file name encoding for ZIP files.
+  If you have unicode file names, please convert them to byte strings
+  in your desired encoding before passing them to \method{write()}.
+  WinZip interprets all file names as encoded in CP437, also known
+  as DOS Latin.}
+
   \note{Archive names should be relative to the archive root, that is,
         they should not start with a path separator.}
 \end{methoddesc}