From: Ilia Alshanetsky <iliaa@php.net>
Date: Mon, 13 Nov 2006 22:11:02 +0000 (+0000)
Subject: MFB: Fixed bug #36812 (pg_execute() modifies input array).
X-Git-Tag: RELEASE_1_0_0RC1~1022
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=cae55a69eb6d7681538920ca13d92f9fc8d51125;p=php

MFB: Fixed bug #36812 (pg_execute() modifies input array).
---

diff --git a/ext/pgsql/pgsql.c b/ext/pgsql/pgsql.c
index 65b6579929..f8dfbcea9e 100644
--- a/ext/pgsql/pgsql.c
+++ b/ext/pgsql/pgsql.c
@@ -1472,6 +1472,7 @@ PHP_FUNCTION(pg_execute)
 		php_error_docref(NULL TSRMLS_CC, E_NOTICE, "Found results on this connection. Use pg_get_result() to get these results first");
 	}
 
+	SEPARATE_ZVAL(pv_param_arr);
 	zend_hash_internal_pointer_reset(Z_ARRVAL_PP(pv_param_arr));
 	num_params = zend_hash_num_elements(Z_ARRVAL_PP(pv_param_arr));
 	if (num_params > 0) {
@@ -1486,7 +1487,8 @@ PHP_FUNCTION(pg_execute)
 			}
 
 			otype = (*tmp)->type;
-			convert_to_string(*tmp);
+			SEPARATE_ZVAL(tmp);
+			convert_to_string_ex(tmp);
 			if (Z_TYPE_PP(tmp) != IS_STRING) {
 				php_error_docref(NULL TSRMLS_CC, E_WARNING,"Error converting parameter");
 				_php_pgsql_free_params(params, num_params);
@@ -1495,8 +1497,7 @@ PHP_FUNCTION(pg_execute)
 
 			if (otype == IS_NULL) {
 				params[i] = NULL;
-			}
-			else {
+			} else {
 				params[i] = Z_STRVAL_PP(tmp);
 			}