From: James Housley <jim@thehousleys.net>
Date: Wed, 18 Jul 2007 18:31:34 +0000 (+0000)
Subject: As has been pointed out, err_msg should not be freed here.  The actual
X-Git-Tag: curl-7_17_0-preldapfix~81
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=ca1356702a64ee4c80a076d74c84f649b425644a;p=curl

As has been pointed out, err_msg should not be freed here.  The actual
issue is in libssh2 and not freeing a dynamic error message during cleanup.
---

diff --git a/lib/ssh.c b/lib/ssh.c
index 141ebebf4..ca4d2ac61 100644
--- a/lib/ssh.c
+++ b/lib/ssh.c
@@ -1643,7 +1643,6 @@ static CURLcode ssh_statemach_act(struct connectdata *conn)
                                                &err_msg, NULL, 0);
           err = libssh2_session_error_to_CURLE(ssh_err);
           failf(conn->data, "%s", err_msg);
-          Curl_safefree(err_msg);
           state(conn, SSH_SCP_CHANNEL_FREE);
           sshc->actualCode = err;
           break;
@@ -1686,7 +1685,6 @@ static CURLcode ssh_statemach_act(struct connectdata *conn)
                                                  &err_msg, NULL, 0);
             err = libssh2_session_error_to_CURLE(ssh_err);
             failf(conn->data, "%s", err_msg);
-            Curl_safefree(err_msg);
             state(conn, SSH_SCP_CHANNEL_FREE);
             sshc->actualCode = err;
             break;