From: Nikita Popov <nikita.ppv@gmail.com>
Date: Mon, 15 Jul 2019 15:26:26 +0000 (+0200)
Subject: Support <?php followed by EOF
X-Git-Tag: php-7.4.0beta1~104
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c9acc9018629d046679fcdccabd4a4f556b87499;p=php

Support <?php followed by EOF

This is an annoying edge-case for canonicalization.
---

diff --git a/UPGRADING b/UPGRADING
index 66b1281972..25e62eed73 100644
--- a/UPGRADING
+++ b/UPGRADING
@@ -34,6 +34,10 @@ PHP 7.4 UPGRADE NOTES
   . Passing the result of a (non-reference) list() assignment by reference is
     consistently disallowed now. Previously this worked if the right hand side
     was a simple (CV) variable and did not occur as part of the list().
+  . `<?php` at the end of the file (without trailing newline) will now be
+    interpreted as an opening PHP tag. Previously it was interpreted either as
+    `<? php` and resulted in a syntax error (with short_open_tag=1) or was
+    interpreted as a literal `<?php` string (with short_open_tag=0).
 
 - BCMath:
   . BCMath functions will now warn if a non well-formed number is passed, such
diff --git a/Zend/tests/php_tag_only.inc b/Zend/tests/php_tag_only.inc
new file mode 100644
index 0000000000..a81436628e
--- /dev/null
+++ b/Zend/tests/php_tag_only.inc
@@ -0,0 +1 @@
+<?php
\ No newline at end of file
diff --git a/Zend/tests/php_tag_only.phpt b/Zend/tests/php_tag_only.phpt
new file mode 100644
index 0000000000..0d01180c8f
--- /dev/null
+++ b/Zend/tests/php_tag_only.phpt
@@ -0,0 +1,5 @@
+--TEST--
+File with just a <?php tag should be valid
+--FILE_EXTERNAL--
+php_tag_only.inc
+--EXPECT--
diff --git a/Zend/zend_language_scanner.l b/Zend/zend_language_scanner.l
index c9539ce881..5824b6b763 100644
--- a/Zend/zend_language_scanner.l
+++ b/Zend/zend_language_scanner.l
@@ -2031,6 +2031,20 @@ string:
 	RETURN_OR_SKIP_TOKEN(T_OPEN_TAG);
 }
 
+<INITIAL>"<?php" {
+	/* Allow <?php followed by end of file. */
+	if (YYCURSOR == YYLIMIT) {
+		BEGIN(ST_IN_SCRIPTING);
+		RETURN_OR_SKIP_TOKEN(T_OPEN_TAG);
+	}
+	/* Degenerate case: <?phpX is interpreted as <? phpX with short tags. */
+	if (CG(short_tags)) {
+		yyless(2);
+		BEGIN(ST_IN_SCRIPTING);
+		RETURN_OR_SKIP_TOKEN(T_OPEN_TAG);
+	}
+	goto inline_char_handler;
+}
 
 <INITIAL>"<?" {
 	if (CG(short_tags)) {
diff --git a/ext/tokenizer/tests/php_tag_only.phpt b/ext/tokenizer/tests/php_tag_only.phpt
new file mode 100644
index 0000000000..a6df7ded4d
--- /dev/null
+++ b/ext/tokenizer/tests/php_tag_only.phpt
@@ -0,0 +1,19 @@
+--TEST--
+Tokenization of only the <?php tag
+--FILE--
+<?php
+
+foreach (token_get_all("<?php") as $token) {
+    echo token_name($token[0]), "\n";
+}
+echo "\n";
+foreach (token_get_all("Foobar<?php") as $token) {
+    echo token_name($token[0]), "\n";
+}
+
+?>
+--EXPECT--
+T_OPEN_TAG
+
+T_INLINE_HTML
+T_OPEN_TAG