From: Matthew Fernandez <matthew.fernandez@gmail.com>
Date: Sat, 19 Jun 2021 20:16:56 +0000 (-0700)
Subject: fix typo in eqEndSeg
X-Git-Tag: 2.48.0~33^2~1
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c929ac09bdc7b4f47f502aec0a4e3174435f607d;p=graphviz

fix typo in eqEndSeg

This fixes a typo which was causing this function to check equality incorrectly.
Unfortunately this seems to have no effect on any open ortho-related bugs.
Closes #2047.
---

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 93be74679..31ae52447 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -11,6 +11,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - updated Graphviz bug report URL in the Autotools build system
 - Fix `WIN32` path of `gvc.def` specified in `libgvc_la_LDFLAGS`
 
+### Fixed
+
+- ortho's eqEndSeg incorrectly modifies its arguments #2047
+
 ## [2.47.3] - 2021-06-19
 
 ### Changed
diff --git a/lib/ortho/ortho.c b/lib/ortho/ortho.c
index dff7eebe3..eb3523bfd 100644
--- a/lib/ortho/ortho.c
+++ b/lib/ortho/ortho.c
@@ -607,7 +607,7 @@ create_graphs(Dt_t* chans)
 static int
 eqEndSeg (bend S1l2, bend S2l2, bend T1, bend T2)
 {
-    if (((S1l2==T2)&&(S2l2=!T2))
+    if (((S1l2==T2)&&(S2l2!=T2))
      || ((S1l2==B_NODE)&&(S2l2==T1)))
 	return(0);
     else