From: Christian Hofstaedtler <christian@hofstaedtler.name>
Date: Tue, 28 Jan 2014 12:32:36 +0000 (+0100)
Subject: Fix segfault in BindBackend on broken AXFR
X-Git-Tag: rec-3.6.0-rc1~215^2
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c919b27e5be189acf70e426abc711fe9027b1275;p=pdns

Fix segfault in BindBackend on broken AXFR

When an AXFR would abort before beginning a transaction, bindbackend
would crash.
---

diff --git a/modules/bindbackend/bindbackend2.cc b/modules/bindbackend/bindbackend2.cc
index 251b1d565..003ce9d76 100644
--- a/modules/bindbackend/bindbackend2.cc
+++ b/modules/bindbackend/bindbackend2.cc
@@ -167,6 +167,9 @@ bool Bind2Backend::startTransaction(const string &qname, int id)
     d_transaction_id=id;
     return true;
   }
+  if(id == 0) {
+    throw DBException("domain_id 0 is invalid for this backend.");
+  }
   shared_ptr<State> state = getState(); 
 
   const BB2DomainInfo &bbd=state->id_zone_map[d_transaction_id=id];
@@ -207,7 +210,10 @@ bool Bind2Backend::commitTransaction()
 
 bool Bind2Backend::abortTransaction()
 {
-  if(d_transaction_id >= 0) {
+  // -1 = dnssec speciality
+  // 0  = invalid transact
+  // >0 = actual transaction
+  if(d_transaction_id > 0) {
     delete d_of;
     d_of=0;
     unlink(d_transaction_tmpname.c_str());