From: Joe Conway <mail@joeconway.com>
Date: Sat, 3 Jan 2009 19:57:54 +0000 (+0000)
Subject: Fix bug per Oleksiy Shchukin - 2nd argument for dblink_get_result(text,bool)
X-Git-Tag: REL8_3_6~22
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c8fad375dbd795a961c77bc9272e80432c4e8bf1;p=postgresql

Fix bug per Oleksiy Shchukin - 2nd argument for dblink_get_result(text,bool)
is PG_GETARG_BOOL(2), should be PG_GETARG_BOOL(1).

Apply simple fix to back branches only. More extensive change to be applied
to head per Tom's suggestion.
---

diff --git a/contrib/dblink/dblink.c b/contrib/dblink/dblink.c
index 9c92ee5176..234d84cf83 100644
--- a/contrib/dblink/dblink.c
+++ b/contrib/dblink/dblink.c
@@ -8,7 +8,7 @@
  * Darko Prenosil <Darko.Prenosil@finteh.hr>
  * Shridhar Daithankar <shridhar_daithankar@persistent.co.in>
  *
- * $PostgreSQL: pgsql/contrib/dblink/dblink.c,v 1.69.2.1 2008/11/30 23:24:01 tgl Exp $
+ * $PostgreSQL: pgsql/contrib/dblink/dblink.c,v 1.69.2.2 2009/01/03 19:57:54 joe Exp $
  * Copyright (c) 2001-2008, PostgreSQL Global Development Group
  * ALL RIGHTS RESERVED;
  *
@@ -809,7 +809,7 @@ dblink_record_internal(FunctionCallInfo fcinfo, bool is_async, bool do_get)
 			{
 				/* text,bool */
 				DBLINK_GET_CONN;
-				fail = PG_GETARG_BOOL(2);
+				fail = PG_GETARG_BOOL(1);
 			}
 			else if (PG_NARGS() == 1)
 			{