From: Lars Hjemli <hjemli@gmail.com>
Date: Mon, 23 May 2011 21:10:37 +0000 (+0200)
Subject: ui-repolist.c: do not return random/stale data from read_agefile
X-Git-Tag: v0.9.0.1~7
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c8ea73caabcb16ffb74baa70d35650027ed772c4;p=cgit

ui-repolist.c: do not return random/stale data from read_agefile

When git/date.c:parse_date() cannot parse its input it returns -1. But
read_agefile() checks if the result is different from zero, essentialy
returning random data from the date buffer when parsing fails. This
patch fixes the issue by verifying that the result from parse_date()
is positive.

Noticed-by: Julius Plenz <plenz@cis.fu-berlin.de>
Signed-off-by: Lars Hjemli <hjemli@gmail.com>
---

diff --git a/ui-repolist.c b/ui-repolist.c
index 2c98668..e138f59 100644
--- a/ui-repolist.c
+++ b/ui-repolist.c
@@ -20,7 +20,7 @@ time_t read_agefile(char *path)
 	if (readfile(path, &buf, &size))
 		return -1;
 
-	if (parse_date(buf, buf2, sizeof(buf2)))
+	if (parse_date(buf, buf2, sizeof(buf2)) > 0)
 		result = strtoul(buf2, NULL, 10);
 	else
 		result = 0;