From: Azat Khuzhin <azat@libevent.org>
Date: Sat, 9 Jul 2022 14:17:38 +0000 (+0300)
Subject: http: suppress "flags may be used uninitialized in this function" error
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c8501afc0cde1a1d8f95daf293ea9fc7feff6e59;p=libevent

http: suppress "flags may be used uninitialized in this function" error

Some GCC reports [1]:

    /home/runner/work/libevent/libevent/http.c: In function ‘evhttp_make_header’:
    /home/runner/work/libevent/libevent/http.c:503:14: error: ‘flags’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
      ev_uint16_t flags;
                  ^~~~~
    /home/runner/work/libevent/libevent/http.c: In function ‘evhttp_get_body’:
    /home/runner/work/libevent/libevent/http.c:2354:14: error: ‘flags’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
      ev_uint16_t flags;
                  ^~~~~
  [1]: https://github.com/libevent/libevent/runs/7263518338?check_suite_focus=true#logs
---

diff --git a/http.c b/http.c
index 9cebbb7c..d578735d 100644
--- a/http.c
+++ b/http.c
@@ -500,7 +500,8 @@ evhttp_make_header_request(struct evhttp_connection *evcon,
     struct evhttp_request *req)
 {
 	const char *method;
-	ev_uint16_t flags;
+	/* NOTE: some version of GCC reports a warning that flags may be uninitialized, hence assignment */
+	ev_uint16_t flags = 0;
 
 	evhttp_remove_header(req->output_headers, "Proxy-Connection");
 
@@ -2351,7 +2352,8 @@ evhttp_get_body_length(struct evhttp_request *req)
 static int
 evhttp_method_may_have_body_(struct evhttp_connection *evcon, enum evhttp_cmd_type type)
 {
-	ev_uint16_t flags;
+	/* NOTE: some version of GCC reports a warning that flags may be uninitialized, hence assignment */
+	ev_uint16_t flags = 0;
 	evhttp_method_(evcon, type, &flags);
 	return (flags & EVHTTP_METHOD_HAS_BODY) ? 1 : 0;
 }