From: Eric Fiselier Date: Mon, 31 Oct 2016 23:07:15 +0000 (+0000) Subject: [modules] Mark deleted functions as implicitly inline to allow merging X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c83b7ade50907144db11f28c4b97b5be2cc84683;p=clang [modules] Mark deleted functions as implicitly inline to allow merging Summary: When merging definitions with ModulesLocalVisibility enabled it's important to make deleted definitions implicitly inline, otherwise they'll be diagnosed as a redefinition. Reviewers: silvas, manmanren, rsmith Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D26143 git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@285655 91177308-0d34-0410-b5e6-96231b3b80d8 --- diff --git a/lib/Sema/SemaDeclCXX.cpp b/lib/Sema/SemaDeclCXX.cpp index 2c743673f6..17d1978de0 100644 --- a/lib/Sema/SemaDeclCXX.cpp +++ b/lib/Sema/SemaDeclCXX.cpp @@ -13875,6 +13875,9 @@ void Sema::SetDeclDeleted(Decl *Dcl, SourceLocation DelLoc) { if (Fn->isMain()) Diag(DelLoc, diag::err_deleted_main); + // C++11 [dcl.fct.def.delete]p4: + // A deleted function is implicitly inline. + Fn->setImplicitlyInline(); Fn->setDeletedAsWritten(); } diff --git a/test/Modules/Inputs/merge-decl-context/a.h b/test/Modules/Inputs/merge-decl-context/a.h index 7be90b1535..a0b58a7d6d 100644 --- a/test/Modules/Inputs/merge-decl-context/a.h +++ b/test/Modules/Inputs/merge-decl-context/a.h @@ -24,5 +24,6 @@ inline A ff(int i) { struct Aggregate { int member; }; +bool operator==(Aggregate, Aggregate) = delete; #endif