From: Fariborz Jahanian <fjahanian@apple.com>
Date: Thu, 16 Jun 2011 20:14:50 +0000 (+0000)
Subject: Move computation of __private_extern__ visibilty to
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c7c9058f4977ef4584d68718e23f34504b150ef4;p=clang

Move computation of __private_extern__ visibilty to
getLVForNamespaceScopeDecl(). // rdar://9609649


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@133182 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/lib/AST/Decl.cpp b/lib/AST/Decl.cpp
index 8661e7405f..c2abe1a5a9 100644
--- a/lib/AST/Decl.cpp
+++ b/lib/AST/Decl.cpp
@@ -231,6 +231,14 @@ static LinkageInfo getLVForNamespaceScopeDecl(const NamedDecl *D, LVFlags F) {
       if (!FoundExtern)
         return LinkageInfo::internal();
     }
+    if (Var->getStorageClass() == SC_None) {
+      const VarDecl *PrevVar = Var->getPreviousDeclaration();
+      for (; PrevVar; PrevVar = PrevVar->getPreviousDeclaration())
+        if (PrevVar->getStorageClass() == SC_PrivateExtern)
+          break;
+        if (PrevVar)
+          return PrevVar->getLinkageAndVisibility();
+    }
   } else if (isa<FunctionDecl>(D) || isa<FunctionTemplateDecl>(D)) {
     // C++ [temp]p4:
     //   A non-member function template can have internal linkage; any
diff --git a/lib/CodeGen/CodeGenModule.cpp b/lib/CodeGen/CodeGenModule.cpp
index c15ef9b089..78c57b4e3f 100644
--- a/lib/CodeGen/CodeGenModule.cpp
+++ b/lib/CodeGen/CodeGenModule.cpp
@@ -206,17 +206,8 @@ void CodeGenModule::setGlobalVisibility(llvm::GlobalValue *GV,
 
   // Set visibility for definitions.
   NamedDecl::LinkageInfo LV = D->getLinkageAndVisibility();
-  if (LV.visibilityExplicit() || !GV->hasAvailableExternallyLinkage()) {
-    Visibility Vis = LV.visibility();
-    if (Vis == DefaultVisibility)
-      if (const VarDecl *VD = dyn_cast<VarDecl>(D))
-        if (const VarDecl *Old = VD->getPreviousDeclaration()) {
-          Visibility OldVis = Old->getLinkageAndVisibility().visibility();
-          if (OldVis == HiddenVisibility)
-            Vis = HiddenVisibility;
-        }
-    GV->setVisibility(GetLLVMVisibility(Vis));
-  }
+  if (LV.visibilityExplicit() || !GV->hasAvailableExternallyLinkage())
+    GV->setVisibility(GetLLVMVisibility(LV.visibility()));
 }
 
 /// Set the symbol visibility of type information (vtable and RTTI)