From: Kevin McCarthy <kevin@8t8.us>
Date: Sat, 19 Jan 2019 23:23:32 +0000 (-0800)
Subject: Change $pgp_use_gpg_agent to default set.
X-Git-Tag: mutt-1-12-rel~129
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c764b995cf31f636466ddbdda97b491d7204f461;p=mutt

Change $pgp_use_gpg_agent to default set.

GnuPG 2.1.0, released in 2014-11-06, automatically spawns an agent.
After 4+ years, it has reached wide enough usage to merit changing the
default.
---

diff --git a/init.h b/init.h
index a22f2542..4d20154a 100644
--- a/init.h
+++ b/init.h
@@ -2393,12 +2393,24 @@ struct option_t MuttVars[] = {
   ** not used.
   ** (PGP only)
   */
-  { "pgp_use_gpg_agent", DT_BOOL, R_NONE, OPTUSEGPGAGENT, 0},
+  { "pgp_use_gpg_agent", DT_BOOL, R_NONE, OPTUSEGPGAGENT, 1},
   /*
   ** .pp
-  ** If \fIset\fP, mutt will use a possibly-running \fCgpg-agent(1)\fP process.
-  ** Note that as of version 2.1, GnuPG no longer exports GPG_AGENT_INFO, so
-  ** mutt no longer verifies if the agent is running.
+  ** If \fIset\fP, mutt expects a \fCgpg-agent(1)\fP process will handle
+  ** private key passphrase prompts.  If \fIunset\fP, mutt will prompt
+  ** for the passphrase and pass it via stdin to the pgp command.
+  ** .pp
+  ** Note that as of version 2.1, GnuPG automatically spawns an agent
+  ** and requires the agent be used for passphrase management.  Since
+  ** that version is increasingly prevalent, this variable now
+  ** defaults \fIset\fP.
+  ** .pp
+  ** Mutt works with a GUI or curses pinentry program.  A TTY pinentry
+  ** should not be used.
+  ** .pp
+  ** If you are using an older version of GnuPG without an agent running,
+  ** or another encryption program without an agent, you will need to
+  ** \fIunset\fP this variable.
   ** (PGP only)
   */
   { "pgp_verify_command", 	DT_STR, R_NONE, UL &PgpVerifyCommand, 0},