From: Jim Warner Date: Sat, 1 Oct 2022 05:00:00 +0000 (-0500) Subject: top: always validate that p-core/e-core identification X-Git-Tag: v4.0.1rc3~3 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c7568b28fbca2d808e8773c1db939fddf2d00f8a;p=procps-ng top: always validate that p-core/e-core identification Prior to this commit, when the '5' key was struck, top would check for the presence of e-cores just one time. That meant if a some cpu was brought online, and it in turn exposed a new e-core after top has started, users needed a top restart to activate the new '5' feature. So, now we'll check for any e-cores with each '5' key. Signed-off-by: Jim Warner --- diff --git a/src/top/top.c b/src/top/top.c index f3bef9a7..9ae7b1ba 100644 --- a/src/top/top.c +++ b/src/top/top.c @@ -5806,12 +5806,10 @@ static void keys_summary (int ch) { || ((w->rc.combine_cpus)))) show_msg(N_txt(XTRA_modebad_txt)); else { - static int scanned; - if (!scanned) { - for (; scanned < Cpu_cnt; scanned++) - if (CPU_VAL(stat_COR_TYP, scanned) == E_CORE) - break; - } + int scanned; + for (scanned = 0; scanned < Cpu_cnt; scanned++) + if (CPU_VAL(stat_COR_TYP, scanned) == E_CORE) + break; if (scanned < Cpu_cnt) { w->rc.core_types += 1; if (w->rc.core_types > E_CORES_ONLY)