From: Andrew Dunstan <andrew@dunslane.net>
Date: Wed, 2 Feb 2011 17:45:42 +0000 (-0500)
Subject: Add  comment on why we're passing a useless 'false' to the plperl function compiler.
X-Git-Tag: REL9_1_ALPHA4~296
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c73fe72e2735d20aa132640d8fab4e0eca1ced95;p=postgresql

Add  comment on why we're passing a useless 'false' to the plperl function compiler.

It's for compatibility with modules like PostgreSQL::PLPerl::NYTProf.
---

diff --git a/src/pl/plperl/plperl.c b/src/pl/plperl/plperl.c
index ece3931982..2ac7168558 100644
--- a/src/pl/plperl/plperl.c
+++ b/src/pl/plperl/plperl.c
@@ -1422,7 +1422,12 @@ plperl_create_sub(plperl_proc_desc *prodesc, char *s, Oid fn_oid)
 	EXTEND(SP, 4);
 	PUSHs(sv_2mortal(newSVstring(subname)));
 	PUSHs(sv_2mortal(newRV_noinc((SV *) pragma_hv)));
-	PUSHs(&PL_sv_no); /* XXX is $prolog in mkfunc needed any more? */
+	/* 
+	 * Use 'false' for $prolog in mkfunc, which is kept for compatibility
+	 * in case a module such as PostgreSQL::PLPerl::NYTprof replaces
+	 * the function compiler.
+	 */
+	PUSHs(&PL_sv_no); 
 	PUSHs(sv_2mortal(newSVstring(s)));
 	PUTBACK;