From: sr55 Date: Sat, 25 Jan 2014 21:12:38 +0000 (+0000) Subject: WinGui: Tidy up a few cosmetic issues and enable the picture preview code in the... X-Git-Tag: 0.10.0~540 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c70a9eb8cd000862c0f31db19e800a312b2b296e;p=handbrake WinGui: Tidy up a few cosmetic issues and enable the picture preview code in the background so it can get some testing. git-svn-id: svn://svn.handbrake.fr/HandBrake/trunk@5991 b64f7644-9d1e-0410-96f1-a4d463321fa5 --- diff --git a/win/CS/HandBrakeWPF/Properties/Resources.Designer.cs b/win/CS/HandBrakeWPF/Properties/Resources.Designer.cs index 6206412ef..3431412ba 100644 --- a/win/CS/HandBrakeWPF/Properties/Resources.Designer.cs +++ b/win/CS/HandBrakeWPF/Properties/Resources.Designer.cs @@ -682,7 +682,7 @@ namespace HandBrakeWPF.Properties { /// /// Looks up a localized string similar to The preset you are trying to import is from a different version of HandBrake. - ///Some values may be reset to default as a result. + /// It may not be possible to import or some values may be reset to default as a result. /// ///Do you wish to proceed?. /// diff --git a/win/CS/HandBrakeWPF/Properties/Resources.resx b/win/CS/HandBrakeWPF/Properties/Resources.resx index 76ddea9ee..ee4f864f9 100644 --- a/win/CS/HandBrakeWPF/Properties/Resources.resx +++ b/win/CS/HandBrakeWPF/Properties/Resources.resx @@ -491,7 +491,7 @@ Your custom presets have not been updated so you may have to re-create these by The preset you are trying to import is from a different version of HandBrake. -Some values may be reset to default as a result. + It may not be possible to import or some values may be reset to default as a result. Do you wish to proceed? diff --git a/win/CS/HandBrakeWPF/ViewModels/Interfaces/IStaticPreviewViewModel.cs b/win/CS/HandBrakeWPF/ViewModels/Interfaces/IStaticPreviewViewModel.cs index a0374b5f1..a1d6b465c 100644 --- a/win/CS/HandBrakeWPF/ViewModels/Interfaces/IStaticPreviewViewModel.cs +++ b/win/CS/HandBrakeWPF/ViewModels/Interfaces/IStaticPreviewViewModel.cs @@ -9,8 +9,6 @@ namespace HandBrakeWPF.ViewModels.Interfaces { - using System.Windows.Media.Imaging; - using HandBrake.ApplicationServices.Model; /// @@ -21,12 +19,9 @@ namespace HandBrakeWPF.ViewModels.Interfaces /// /// The preview frame. /// - /// - /// The image. - /// /// /// The task. /// - void PreviewFrame(BitmapImage image, EncodeTask task); + void UpdatePreviewFrame(EncodeTask task); } } diff --git a/win/CS/HandBrakeWPF/ViewModels/PictureSettingsViewModel.cs b/win/CS/HandBrakeWPF/ViewModels/PictureSettingsViewModel.cs index 9b95d0393..c051b0aad 100644 --- a/win/CS/HandBrakeWPF/ViewModels/PictureSettingsViewModel.cs +++ b/win/CS/HandBrakeWPF/ViewModels/PictureSettingsViewModel.cs @@ -823,12 +823,9 @@ namespace HandBrakeWPF.ViewModels /// public void PreviewImage() { - IScan scanService = IoC.Get(); - BitmapImage image = scanService.GetPreview(this.Task, 1); - - if (image != null) + if (!string.IsNullOrEmpty(this.Task.Source)) { - this.StaticPreviewViewModel.PreviewFrame(image, this.Task); + this.StaticPreviewViewModel.UpdatePreviewFrame(this.Task); this.WindowManager.ShowWindow(this.StaticPreviewViewModel); } } @@ -1200,19 +1197,9 @@ namespace HandBrakeWPF.ViewModels /// private void UpdatePreviewImage() { - return; - if (delayedPreviewprocessor != null) + if (delayedPreviewprocessor != null && this.Task != null) { - delayedPreviewprocessor.PerformTask(() => - { - IScan scanService = IoC.Get(); - BitmapImage image = scanService.GetPreview(this.Task, 1); - - if (image != null) - { - this.StaticPreviewViewModel.PreviewFrame(image, this.Task); - } - }, 800); + delayedPreviewprocessor.PerformTask(() => this.StaticPreviewViewModel.UpdatePreviewFrame(this.Task), 800); } } diff --git a/win/CS/HandBrakeWPF/ViewModels/StaticPreviewViewModel.cs b/win/CS/HandBrakeWPF/ViewModels/StaticPreviewViewModel.cs index d836f6d49..fd683fc2a 100644 --- a/win/CS/HandBrakeWPF/ViewModels/StaticPreviewViewModel.cs +++ b/win/CS/HandBrakeWPF/ViewModels/StaticPreviewViewModel.cs @@ -172,21 +172,11 @@ namespace HandBrakeWPF.ViewModels #region Public Methods and Operators - /// - /// The preview frame. - /// - /// - /// The image. - /// - /// - /// The task. - /// - public void PreviewFrame(BitmapImage image, EncodeTask task) + public void UpdatePreviewFrame(EncodeTask task) { this.Task = task; - this.Width = (int)Math.Ceiling(image.Width); - this.Height = (int)Math.Ceiling(image.Height); - this.PreviewImage = image; + this.UpdatePreviewFrame(); + this.DisplayName = "Picture Preview"; } /// @@ -198,10 +188,11 @@ namespace HandBrakeWPF.ViewModels if (image != null) { - this.PreviewFrame(image, this.Task); + this.Width = (int)Math.Ceiling(image.Width); + this.Height = (int)Math.Ceiling(image.Height); + this.PreviewImage = image; } } - #endregion } } \ No newline at end of file diff --git a/win/CS/HandBrakeWPF/ViewModels/ViewModelBase.cs b/win/CS/HandBrakeWPF/ViewModels/ViewModelBase.cs index 301e161dd..1e6946b8a 100644 --- a/win/CS/HandBrakeWPF/ViewModels/ViewModelBase.cs +++ b/win/CS/HandBrakeWPF/ViewModels/ViewModelBase.cs @@ -11,8 +11,6 @@ namespace HandBrakeWPF.ViewModels { using Caliburn.Micro; - using HandBrake.ApplicationServices.Services.Interfaces; - using HandBrakeWPF.Helpers; using HandBrakeWPF.Services.Interfaces; using HandBrakeWPF.ViewModels.Interfaces; diff --git a/win/CS/HandBrakeWPF/Views/MainView.xaml b/win/CS/HandBrakeWPF/Views/MainView.xaml index 591d83227..2d8f613d9 100644 --- a/win/CS/HandBrakeWPF/Views/MainView.xaml +++ b/win/CS/HandBrakeWPF/Views/MainView.xaml @@ -149,19 +149,8 @@ - - - - + diff --git a/win/CS/HandBrakeWPF/Views/PictureSettingsView.xaml b/win/CS/HandBrakeWPF/Views/PictureSettingsView.xaml index 2a5d136bc..a39719959 100644 --- a/win/CS/HandBrakeWPF/Views/PictureSettingsView.xaml +++ b/win/CS/HandBrakeWPF/Views/PictureSettingsView.xaml @@ -14,142 +14,150 @@ - - - + + - - - - - + + + diff --git a/win/CS/HandBrakeWPF/Views/QueueView.xaml b/win/CS/HandBrakeWPF/Views/QueueView.xaml index 62181977e..f1d8ccdf4 100644 --- a/win/CS/HandBrakeWPF/Views/QueueView.xaml +++ b/win/CS/HandBrakeWPF/Views/QueueView.xaml @@ -152,7 +152,7 @@ - +