From: Zachary Ware <zachary.ware@gmail.com>
Date: Fri, 1 Aug 2014 04:58:27 +0000 (-0500)
Subject: Issue #21907: Avoid using double quotes to check argument values.
X-Git-Tag: v3.5.0a1~1149
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c6f8c0a1de448e7ca62ece1d21f089194d31f0d9;p=python

Issue #21907: Avoid using double quotes to check argument values.

Double quotes in expanded variables can match literal double quotes,
which makes for a big mess when passing in a quoted argument (like
"/p:externalsDir=..\externals", for example).
---

diff --git a/PCbuild/build.bat b/PCbuild/build.bat
index cde88c5a7a..838f6ef763 100644
--- a/PCbuild/build.bat
+++ b/PCbuild/build.bat
@@ -16,13 +16,13 @@ set target=Build
 set dir=%~dp0
 
 :CheckOpts
-if "%1"=="-c" (set conf=%2) & shift & shift & goto CheckOpts
-if "%1"=="-p" (set platf=%2) & shift & shift & goto CheckOpts
-if "%1"=="-r" (set target=Rebuild) & shift & goto CheckOpts
-if "%1"=="-d" (set conf=Debug) & shift & goto CheckOpts
-if "%1"=="-e" call "%dir%get_externals.bat" & shift & goto CheckOpts
+if '%1'=='-c' (set conf=%2) & shift & shift & goto CheckOpts
+if '%1'=='-p' (set platf=%2) & shift & shift & goto CheckOpts
+if '%1'=='-r' (set target=Rebuild) & shift & goto CheckOpts
+if '%1'=='-d' (set conf=Debug) & shift & goto CheckOpts
+if '%1'=='-e' call "%dir%get_externals.bat" & shift & goto CheckOpts
 
-if "%platf%"=="x64" (set vs_platf=x86_amd64)
+if '%platf%'=='x64' (set vs_platf=x86_amd64)
 
 rem Setup the environment
 call "%VS100COMNTOOLS%..\..\VC\vcvarsall.bat" %vs_platf%