From: Wez Furlong <wez@php.net>
Date: Tue, 25 May 2004 12:59:15 +0000 (+0000)
Subject: In debug mode, under CLI don't close stderr.
X-Git-Tag: php-5.0.0RC3RC1~53
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c6dff79138f5e399ee4de1d9f22d02f41b9d5c0c;p=php

In debug mode, under CLI don't close stderr.
This is so that we can see any error reports.

# for extra paranoia, could limit this check to happen only after the script is
# finished running.
---

diff --git a/main/streams/plain_wrapper.c b/main/streams/plain_wrapper.c
index b1b27f6049..9a4027ec9a 100644
--- a/main/streams/plain_wrapper.c
+++ b/main/streams/plain_wrapper.c
@@ -428,7 +428,16 @@ static int php_stdiop_close(php_stream *stream, int close_handle TSRMLS_DC)
 				data->file = NULL;
 			}
 		} else if (data->fd != -1) {
+#ifdef DEBUG
+			if (data->fd == 2 && strcmp(sapi_module.name, "cli")) {
+				/* don't close stderr in CLI in DEBUG mode, as we want to see any leaks */
+				ret = 0;
+			} else {
+				ret = close(data->fd);
+			}
+#else
 			ret = close(data->fd);
+#endif
 			data->fd = -1;
 		} else {
 			return 0; /* everything should be closed already -> success */