From: Daniel Lowrey <rdlowrey@php.net>
Date: Wed, 11 Mar 2015 15:44:07 +0000 (-0600)
Subject: Don't block on crypto data inside stream_select()
X-Git-Tag: php-5.6.8RC1~84
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c66112145993aaf271acd436a5d830783ad4c5ed;p=php

Don't block on crypto data inside stream_select()
---

diff --git a/ext/openssl/xp_ssl.c b/ext/openssl/xp_ssl.c
index f74edd23ad..adef9120d6 100644
--- a/ext/openssl/xp_ssl.c
+++ b/ext/openssl/xp_ssl.c
@@ -2284,17 +2284,13 @@ static int php_openssl_sockop_cast(php_stream *stream, int castas, void **ret TS
 
 		case PHP_STREAM_AS_FD_FOR_SELECT:
 			if (ret) {
-				if (sslsock->ssl_active) {
-					/* OpenSSL has an internal buffer which select() cannot see. If we don't
-					   fetch it into the stream's buffer, no activity will be reported on the
-					   stream even though there is data waiting to be read - but we only fetch
-					   the number of bytes OpenSSL has ready to give us since we weren't asked
-					   for any data at this stage. This is only likely to cause issues with
-					   non-blocking streams, but it's harmless to always do it. */
-					int bytes;
-					while ((bytes = SSL_pending(sslsock->ssl_handle)) > 0) {
-						php_stream_fill_read_buffer(stream, (size_t)bytes);
-					}
+				size_t pending;
+				if (stream->writepos == stream->readpos
+					&& sslsock->ssl_active
+					&& (pending = (size_t)SSL_pending(sslsock->ssl_handle)) > 0) {
+						php_stream_fill_read_buffer(stream, pending < stream->chunk_size
+							? pending
+							: stream->chunk_size);
 				}
 
 				*(int *)ret = sslsock->s.socket;