From: Steve Dower <steve.dower@microsoft.com>
Date: Fri, 2 Jun 2017 21:39:05 +0000 (-0700)
Subject: bpo-30544: _io._WindowsConsoleIO.write raises the wrong error when WriteConsoleW... 
X-Git-Tag: v3.6.2rc1~104
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c63ae1122f84d4188ffadfd1454902093eb10be1;p=python

bpo-30544: _io._WindowsConsoleIO.write raises the wrong error when WriteConsoleW fails (#1912) (#1925)

* bpo-30544: _io._WindowsConsoleIO.write raises the wrong error when WriteConsoleW fails

* bpo-30544: _io._WindowsConsoleIO.write raises the wrong error when WriteConsoleW fails
---

diff --git a/Modules/_io/winconsoleio.c b/Modules/_io/winconsoleio.c
index 1d169e2764..cbe21422bb 100644
--- a/Modules/_io/winconsoleio.c
+++ b/Modules/_io/winconsoleio.c
@@ -1017,7 +1017,7 @@ _io__WindowsConsoleIO_write_impl(winconsoleio *self, Py_buffer *b)
     wlen = MultiByteToWideChar(CP_UTF8, 0, b->buf, len, wbuf, wlen);
     if (wlen) {
         res = WriteConsoleW(self->handle, wbuf, wlen, &n, NULL);
-        if (n < wlen) {
+        if (res && n < wlen) {
             /* Wrote fewer characters than expected, which means our
              * len value may be wrong. So recalculate it from the
              * characters that were written. As this could potentially