From: Zachary Turner <zturner@google.com>
Date: Wed, 22 Mar 2017 16:30:06 +0000 (+0000)
Subject: Make the home_directory test a little more resilient.
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c5caccf493e1d8b95196eef8bdf2057705e792a5;p=llvm

Make the home_directory test a little more resilient.

It's possible (albeit strange) for $HOME to intentionally
point somewhere other than the user's home directory as
reported by the password database.  Our test shouldn't fail
in this case.  This patch updates the test to pull directly
from the password database before unsetting $HOME, rather
than comparing the return value of home_directory() to the
original value of the environment variable.

git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@298514 91177308-0d34-0410-b5e6-96231b3b80d8
---

diff --git a/unittests/Support/Path.cpp b/unittests/Support/Path.cpp
index afa5a5a0d46..86ad57f3f3f 100644
--- a/unittests/Support/Path.cpp
+++ b/unittests/Support/Path.cpp
@@ -28,6 +28,7 @@
 #endif
 
 #ifdef LLVM_ON_UNIX
+#include <pwd.h>
 #include <sys/stat.h>
 #endif
 
@@ -328,23 +329,33 @@ TEST(Support, HomeDirectory) {
   }
 }
 
-#ifndef LLVM_ON_WIN32
+#ifdef LLVM_ON_UNIX
 TEST(Support, HomeDirectoryWithNoEnv) {
-  std::string Original;
-  char const *path = ::getenv("HOME");
-  // Don't try to test if we don't have something to compare against.
-  if (!path)
-    return;
-  Original = path;
+  std::string OriginalStorage;
+  char const *OriginalEnv = ::getenv("HOME");
+  if (OriginalEnv) {
+    // We're going to unset it, so make a copy and save a pointer to the copy
+    // so that we can reset it at the end of the test.
+    OriginalStorage = OriginalEnv;
+    OriginalEnv = OriginalStorage.c_str();
+  }
+
+  // Don't run the test if we have nothing to compare against.
+  struct passwd *pw = getpwuid(getuid());
+  if (!pw || !pw->pw_dir) return;
+
   ::unsetenv("HOME");
+  EXPECT_EQ(nullptr, ::getenv("HOME"));
+  std::string PwDir = pw->pw_dir;
 
   SmallString<128> HomeDir;
   auto status = path::home_directory(HomeDir);
   EXPECT_TRUE(status);
-  EXPECT_EQ(Original, HomeDir);
+  EXPECT_EQ(PwDir, HomeDir);
 
-  // Now put the original environment variable back
-  ::setenv("HOME", Original.c_str(), 1);
+  // Now put the environment back to its original state (meaning that if it was
+  // unset before, we don't reset it).
+  if (OriginalEnv) ::setenv("HOME", OriginalEnv, 1);
 }
 #endif