From: Christian Stocker <chregu@php.net>
Date: Fri, 28 May 2004 13:04:19 +0000 (+0000)
Subject: fix memleak in php callbacks
X-Git-Tag: php-5.0.0RC3RC2~80
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c59471cd1f15a9120612fc7bc91893ecabe28aa3;p=php

fix memleak in php callbacks
---

diff --git a/ext/xsl/xsltprocessor.c b/ext/xsl/xsltprocessor.c
index 10c7e668a3..2d99d18ac3 100644
--- a/ext/xsl/xsltprocessor.c
+++ b/ext/xsl/xsltprocessor.c
@@ -246,7 +246,6 @@ static void xsl_ext_function_php(xmlXPathParserContextPtr ctxt, int nargs, int t
 	/*fci.function_handler_cache = &function_ptr;*/
 	if (!zend_make_callable(&handler, &callable TSRMLS_CC)) {
 		php_error_docref(NULL TSRMLS_CC, E_WARNING, "Unable to call handler %s()", callable);
-		efree(callable);
 		
 	} else {
 		result = zend_call_function(&fci, NULL TSRMLS_CC);
@@ -273,6 +272,7 @@ static void xsl_ext_function_php(xmlXPathParserContextPtr ctxt, int nargs, int t
 			zval_ptr_dtor(&retval);
 		}
 	}
+	efree(callable);
 	zval_dtor(&handler);
 	for (i = 0; i < nargs - 1; i++) {
 		zval_ptr_dtor(&args[i]);