From: Brian Curtin <brian.curtin@gmail.com>
Date: Mon, 1 Nov 2010 14:00:33 +0000 (+0000)
Subject: Close subprocess pipes to clear ResourceWarning messages in debug mode.
X-Git-Tag: v3.2a4~199
X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c4ac887917e4b5d97ff1d761c68a52722044213c;p=python

Close subprocess pipes to clear ResourceWarning messages in debug mode.
---

diff --git a/Lib/test/script_helper.py b/Lib/test/script_helper.py
index f40a676c7a..4cadcf7196 100644
--- a/Lib/test/script_helper.py
+++ b/Lib/test/script_helper.py
@@ -24,6 +24,8 @@ def _assert_python(expected_success, *args):
         out, err = p.communicate()
     finally:
         subprocess._cleanup()
+        p.stdout.close()
+        p.stderr.close()
     rc = p.returncode
     if (rc and expected_success) or (not rc and not expected_success):
         raise AssertionError(
diff --git a/Lib/test/test_cmd_line.py b/Lib/test/test_cmd_line.py
index 0ddc8131f6..e8f8c9d626 100644
--- a/Lib/test/test_cmd_line.py
+++ b/Lib/test/test_cmd_line.py
@@ -231,6 +231,7 @@ sys.stdout.buffer.write(path)"""
             code = '; '.join(code)
             p = _spawn_python_with_env('-S', '-c', code)
             stdout, _ = p.communicate()
+            p.stdout.close()
             self.assertIn(path1.encode('ascii'), stdout)
             self.assertIn(path2.encode('ascii'), stdout)