From: Tom Lane Date: Wed, 22 Nov 2006 21:12:57 +0000 (+0000) Subject: Fix 1-byte buffer overrun when OID exceeds 1 billion. This probably can't X-Git-Tag: REL8_1_6~17 X-Git-Url: https://granicus.if.org/sourcecode?a=commitdiff_plain;h=c4950aa1eeb62b6661b4fb1fc1edb53dba96f98d;p=postgresql Fix 1-byte buffer overrun when OID exceeds 1 billion. This probably can't cause any serious harm in normal cases, but if you have gcc buffer overrun checking turned on, that will notice. Found by Jack Orenstein. Problem was already fixed in CVS HEAD. --- diff --git a/src/bin/psql/common.c b/src/bin/psql/common.c index 1324e557b0..e5b545a4cf 100644 --- a/src/bin/psql/common.c +++ b/src/bin/psql/common.c @@ -3,7 +3,7 @@ * * Copyright (c) 2000-2005, PostgreSQL Global Development Group * - * $PostgreSQL: pgsql/src/bin/psql/common.c,v 1.110.2.3 2006/06/30 16:55:41 alvherre Exp $ + * $PostgreSQL: pgsql/src/bin/psql/common.c,v 1.110.2.4 2006/11/22 21:12:57 tgl Exp $ */ #include "postgres_fe.h" #include "common.h" @@ -903,7 +903,7 @@ PrintQueryResults(PGresult *results) case PGRES_COMMAND_OK: { - char buf[10]; + char buf[16]; success = true; snprintf(buf, sizeof(buf),